Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildscripts/semantic-convention/generate.sh script #2144

Merged
merged 3 commits into from
Dec 1, 2020

Conversation

mateuszrzeszutek
Copy link
Member

Including:

  • update spec version to latest commit
  • regenerate SemanticAttributes

Resolves #2139

Including:
* update spec version to latest commit
* regenerate SemanticAttributes
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #2144 (8770884) into master (14d23dc) will increase coverage by 84.76%.
The diff coverage is 56.06%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2144       +/-   ##
=============================================
+ Coverage          0   84.76%   +84.76%     
- Complexity        0     2170     +2170     
=============================================
  Files             0      246      +246     
  Lines             0     8384     +8384     
  Branches          0      924      +924     
=============================================
+ Hits              0     7107     +7107     
- Misses            0      938      +938     
- Partials          0      339      +339     
Impacted Files Coverage Δ Complexity Δ
...metry/api/trace/attributes/SemanticAttributes.java 74.00% <56.06%> (ø) 1.00 <0.00> (?)
...io/opentelemetry/opencensusshim/SpanConverter.java 81.74% <0.00%> (ø) 28.00% <0.00%> (?%)
...emetry/sdk/extension/aws/resource/Ec2Resource.java 80.00% <0.00%> (ø) 22.00% <0.00%> (?%)
.../opentelemetry/sdk/extension/zpages/ZPageLogo.java 72.72% <0.00%> (ø) 5.00% <0.00%> (?%)
...y/opencensusshim/OpenTelemetryStartEndHandler.java 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...lemetry/sdk/extension/zpages/ZPageHttpHandler.java 55.00% <0.00%> (ø) 9.00% <0.00%> (?%)
...lemetry/sdk/extension/otproto/TraceProtoUtils.java 76.19% <0.00%> (ø) 6.00% <0.00%> (?%)
...lemetry/sdk/trace/samplers/ParentBasedSampler.java 67.79% <0.00%> (ø) 12.00% <0.00%> (?%)
...entelemetry/sdk/trace/export/NoopSpanExporter.java 83.33% <0.00%> (ø) 5.00% <0.00%> (?%)
...y/sdk/trace/samplers/TraceIdRatioBasedSampler.java 100.00% <0.00%> (ø) 10.00% <0.00%> (?%)
... and 237 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d23dc...8770884. Read the comment docs.

@@ -3,9 +3,9 @@
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
ROOT_DIR="${SCRIPT_DIR}/../../"
# freeze the spec version to make SemanticAttributes generation reproducible
# this hash was obtained by calling `git rev-parse master`
# this hash was obtained by calling `git rev-parse master` on 1st Dec 2020
# we can't use a version tag here because otel-spec releases are very rare
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I brought this up in the spec meeting this morning, so it's at least on people's radar.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildscripts/generate.sh is broken
4 participants