-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix buildscripts/semantic-convention/generate.sh script #2144
Fix buildscripts/semantic-convention/generate.sh script #2144
Conversation
Including: * update spec version to latest commit * regenerate SemanticAttributes
Codecov Report
@@ Coverage Diff @@
## master #2144 +/- ##
=============================================
+ Coverage 0 84.76% +84.76%
- Complexity 0 2170 +2170
=============================================
Files 0 246 +246
Lines 0 8384 +8384
Branches 0 924 +924
=============================================
+ Hits 0 7107 +7107
- Misses 0 938 +938
- Partials 0 339 +339
Continue to review full report at Codecov.
|
api/src/main/java/io/opentelemetry/api/trace/attributes/SemanticAttributes.java
Show resolved
Hide resolved
@@ -3,9 +3,9 @@ | |||
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" | |||
ROOT_DIR="${SCRIPT_DIR}/../../" | |||
# freeze the spec version to make SemanticAttributes generation reproducible | |||
# this hash was obtained by calling `git rev-parse master` | |||
# this hash was obtained by calling `git rev-parse master` on 1st Dec 2020 | |||
# we can't use a version tag here because otel-spec releases are very rare |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi I brought this up in the spec meeting this morning, so it's at least on people's radar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Including:
Resolves #2139