Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding span name in spring web library instrumentation #8933

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Allow overriding span name in spring web library instrumentation #8933

merged 1 commit into from
Jul 21, 2023

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jul 12, 2023

Resolves #8839
In spring-webmvc it is still possible that updating route overwrites the name from the span extractor.

@laurit laurit requested a review from a team July 12, 2023 12:16
breedx-splk
breedx-splk approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you work this new behavior into one of the tests please? Even if it just appends an x to the span name or something, it would be nice to see this new functionality have test coverage.

@laurit laurit force-pushed the spring-span-name branch from f45b75c to ddc7ca5 Compare July 21, 2023 11:19
@mateuszrzeszutek mateuszrzeszutek merged commit bd8ddf4 into open-telemetry:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpringWebTelemetry span name contains only HTTP method
3 participants
@laurit @mateuszrzeszutek @breedx-splk