-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SpringWebTelemetry span name contains only HTTP method #8839
Comments
|
Otel specification gives guidelines for naming these spans https://opentelemetry.io/docs/specs/otel/trace/semantic_conventions/http/#name |
It should be a |
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Interceptor created by SpringWebTelemetry creates spans named only by HTTP method. Metadata correctly contains also original URL wich would be much more specific and describing in span. Probably best solution would be to implement getRoute method on SpringWebMvcHttpAttributesGetter which would most probably generate correct name
Describe alternatives you've considered
Change in SpringWebTelemetryBuilder to allow custom name extractor would be also acceptable since user will be able to define its own name extractor which would generate more descriptive names.
Additional context
Used version 1.27.0-alpha
The text was updated successfully, but these errors were encountered: