Fix Restlet v2 Message#getAttributes calls
#6796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
approved these changes
Oct 3, 2022
trask
reviewed
Oct 3, 2022
Honestly, no. It's even more surprising that the muzzle check did not catch it either -- maybe maven coordinates have changed? I'll check that |
mateuszrzeszutek
commented
Oct 4, 2022
Comment on lines
+150
to
+151
| // the project repositories need to be retrieved after evaluation, before that the list is just empty | ||
| val projectRepositories = getProjectRepositories(project) |
There was a problem hiding this comment.
Turns out that the project repositories weren't taken into account (they need to be retrieved afterEvaluate, before that the list is just empty); and since restlet is not available in maven central, muzzle check did nothing.
mateuszrzeszutek
commented
Oct 4, 2022
| @@ -6,7 +6,9 @@ muzzle { | |||
| pass { | |||
| group.set("org.restlet") | |||
| module.set("org.restlet") | |||
| versions.set("[1.0.0, 1.2-M1)") | |||
| // TODO: rename this module to restlet-1.1 | |||
There was a problem hiding this comment.
Will do that in the next PR
mateuszrzeszutek
pushed a commit
that referenced
this pull request
Oct 21, 2022
…6937) Fixes #6932 Replaces #6933 @aaron-ai I finally understood what you meant in #6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 22, 2022
…pen-telemetry#6937) Fixes open-telemetry#6932 Replaces open-telemetry#6933 @aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…pen-telemetry#6937) Fixes open-telemetry#6932 Replaces open-telemetry#6933 @aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…pen-telemetry#6937) Fixes open-telemetry#6932 Replaces open-telemetry#6933 @aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your PR - initially I thought you were talking about some custom extension, that's outside of this repository. I added back the maven central fallback to the muzzle check plugin: after investigating a bit, I found out that the repositories defined in `settings.dependencyResolutionManagement` are not propagated at all (no matter whether it's `afterEvaluate` or not) to the `project.repositories`, and that the gradle issue gradle/gradle#17295 is still valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6563