Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable muzzle scanning for Apache Dubbo and Apache RocketMQ #6932

Closed
aaron-ai opened this issue Oct 21, 2022 · 0 comments · Fixed by #6937
Closed

Enable muzzle scanning for Apache Dubbo and Apache RocketMQ #6932

aaron-ai opened this issue Oct 21, 2022 · 0 comments · Fixed by #6937
Labels
enhancement New feature or request

Comments

@aaron-ai
Copy link
Member

According to #6927, maven central should be added.
@aaron-ai aaron-ai added the enhancement New feature or request label Oct 21, 2022
@aaron-ai aaron-ai mentioned this issue Oct 21, 2022
Closed
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Oct 21, 2022
Merged
mateuszrzeszutek pushed a commit that referenced this issue Oct 21, 2022
Revert removing the mavenCentral repo from the muzzle check plugin (#…
47cbdf3 
…6937)

Fixes #6932 
Replaces #6933 

@aaron-ai I finally understood what you meant in #6796 after seeing your
PR - initially I thought you were talking about some custom extension,
that's outside of this repository.
I added back the maven central fallback to the muzzle check plugin:
after investigating a bit, I found out that the repositories defined in
`settings.dependencyResolutionManagement` are not propagated at all (no
matter whether it's `afterEvaluate` or not) to the
`project.repositories`, and that the gradle issue
gradle/gradle#17295 is still valid.
dmarkwat pushed a commit to dmarkwat/opentelemetry-java-instrumentation that referenced this issue Oct 22, 2022
@dmarkwat
Revert removing the mavenCentral repo from the muzzle check plugin (o…
4f53043 
…pen-telemetry#6937)

Fixes open-telemetry#6932 
Replaces open-telemetry#6933 

@aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your
PR - initially I thought you were talking about some custom extension,
that's outside of this repository.
I added back the maven central fallback to the muzzle check plugin:
after investigating a bit, I found out that the repositories defined in
`settings.dependencyResolutionManagement` are not propagated at all (no
matter whether it's `afterEvaluate` or not) to the
`project.repositories`, and that the gradle issue
gradle/gradle#17295 is still valid.
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this issue Oct 31, 2022
@LironKS
Revert removing the mavenCentral repo from the muzzle check plugin (o…
9b03ea0 
…pen-telemetry#6937)

Fixes open-telemetry#6932 
Replaces open-telemetry#6933 

@aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your
PR - initially I thought you were talking about some custom extension,
that's outside of this repository.
I added back the maven central fallback to the muzzle check plugin:
after investigating a bit, I found out that the repositories defined in
`settings.dependencyResolutionManagement` are not propagated at all (no
matter whether it's `afterEvaluate` or not) to the
`project.repositories`, and that the gradle issue
gradle/gradle#17295 is still valid.
LironKS pushed a commit to helios/opentelemetry-java-instrumentation that referenced this issue Dec 4, 2022
@LironKS
Revert removing the mavenCentral repo from the muzzle check plugin (o…
21324b0 
…pen-telemetry#6937)

Fixes open-telemetry#6932 
Replaces open-telemetry#6933 

@aaron-ai I finally understood what you meant in open-telemetry#6796 after seeing your
PR - initially I thought you were talking about some custom extension,
that's outside of this repository.
I added back the maven central fallback to the muzzle check plugin:
after investigating a bit, I found out that the repositories defined in
`settings.dependencyResolutionManagement` are not propagated at all (no
matter whether it's `afterEvaluate` or not) to the
`project.repositories`, and that the gradle issue
gradle/gradle#17295 is still valid.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@aaron-ai