Avoid looking up annotation types during type matching #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurit
commented
May 11, 2022
Comment on lines
+519
to
+524
| enterLoadAnnotations(); | ||
| try { | ||
| return method.getDeclaredAnnotations(); | ||
| } finally { | ||
| exitLoadAnnotations(); | ||
| } |
There was a problem hiding this comment.
@trask you asked how big of a difference this makes. Calling method.getDeclaredAnnotations() without enterLoadAnnotations produced count=541790, time=1290ms and with enterLoadAnnotations count=541715, time=87ms when starting liferay.
trask
approved these changes
May 12, 2022
mateuszrzeszutek
approved these changes
May 12, 2022
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5791
Like jdk, byte-buddy getDeclaredAnnotations does not report annotations whose class is missing. To do this it needs to locate the bytes for annotation types used in class. Which means that if we have a matcher that matches methods annotated with
@Foobyte-buddy will end up location bytes for all annotations used on any method in the classes that this matcher is applied to. From our perspective this is unreasonable, we just want to match based on annotation name with as little overhead as possible. As we match only based on annotation name we never need to locate the bytes for the annotation type.Implementation is a bit of a hack, so we'll have to consider whether we want to do this at all.