Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup performance #5791

Closed
trask opened this issue Apr 10, 2022 · 1 comment
Closed

Startup performance #5791

trask opened this issue Apr 10, 2022 · 1 comment

Comments

@trask
Copy link
Member

trask commented Apr 10, 2022

Carrying over discussion from #5724:

  • Evil matchers: jax-rs 1, jax-rs 2 annotations, and jax-ws
  • Matchers that match based on annotation (not quite evil, but not highly optimized): external annotations, withspan, spring-ws)

Some performance results from #5724 (comment):

with jaxrs 2 annotations instrumentation:

match count=10154036, time=16974ms
locate count=32589, time=9313ms

with jaxrs 2 annotations instrumentation disabled:

match count=9965431, time=6738ms
locate count=9279, time=2094ms

additionally with external annotations, withspan, spring-ws instrumentations disabled:

match count=9368871, time=4852ms
locate count=3258, time=1008ms

In retrospect I realized that I probably should have counted only the classes located during matching. Then the last test would give

locate count=45, time=19ms
@trask
Copy link
Member Author

trask commented Aug 16, 2023

Closing, startup perf can always be better, but @laurit has made a lot of improvement to it since this was opened

@trask trask closed this as completed Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant