-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Quarkus correlation #4883
Merged
Merged
Fix Quarkus correlation #4883
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5fbe67f
Fix Quarkus correlation
trask f70758e
Add Quarkus smoke test image
trask 8f661b6
Add Quarkus smoke test
trask da318eb
Fix permission on gradlew
trask de57932
Update to gradle 7.3.1
trask 9fa53ad
Fix Jib build
trask bd7acaa
Bump compilation to Java 11
trask 4748e13
Better comment
trask 640a83e
Fix comment placement
trask 1c541cd
Fix
trask File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
name: PR build Quarkus images for smoke tests | ||
|
||
on: | ||
pull_request: | ||
paths: | ||
- 'smoke-tests/images/quarkus/**' | ||
- '.github/workflows/pr-smoke-test-quarkus-images.yml' | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Set up JDK 11 for running Gradle | ||
uses: actions/setup-java@v2 | ||
with: | ||
distribution: adopt | ||
java-version: 11 | ||
|
||
- name: Cache gradle dependencies | ||
uses: burrunan/[email protected] | ||
with: | ||
job-id: quarkus-smoke | ||
read-only: true | ||
|
||
- name: Cache Gradle Wrapper | ||
uses: actions/cache@v2 | ||
with: | ||
path: ~/.gradle/wrapper | ||
key: ${{ runner.os }}-gradle-wrapper-cache-${{ hashFiles('smoke-tests/images/quarkus/gradle/wrapper/gradle-wrapper.properties') }} | ||
|
||
- name: Build Docker Image | ||
# Quarkus 2.0+ does not support Java 8 | ||
run: | | ||
./gradlew jibDockerBuild -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain | ||
./gradlew jibDockerBuild -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain | ||
working-directory: smoke-tests/images/quarkus |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
name: Publish Quarkus images for smoke tests | ||
|
||
on: | ||
push: | ||
paths: | ||
- 'smoke-tests/images/quarkus/**' | ||
- '.github/workflows/publish-smoke-test-quarkus-images.yml' | ||
branches: | ||
- main | ||
workflow_dispatch: | ||
|
||
jobs: | ||
publish: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 0 | ||
|
||
- name: Set up JDK 11 for running Gradle | ||
uses: actions/setup-java@v2 | ||
with: | ||
distribution: adopt | ||
java-version: 11 | ||
|
||
- name: Cache gradle dependencies | ||
uses: burrunan/[email protected] | ||
with: | ||
job-id: quarkus-smoke | ||
read-only: true | ||
|
||
- name: Cache Gradle Wrapper | ||
uses: actions/cache@v2 | ||
with: | ||
path: ~/.gradle/wrapper | ||
key: ${{ runner.os }}-gradle-wrapper-cache-${{ hashFiles('smoke-tests/images/quarkus/gradle/wrapper/gradle-wrapper.properties') }} | ||
|
||
- name: Login to GitHub Package Registry | ||
uses: docker/[email protected] | ||
with: | ||
registry: ghcr.io | ||
username: ${{ github.repository_owner }} | ||
password: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
- name: Build Docker Image | ||
# Quarkus 2.0+ does not support Java 8 | ||
run: | | ||
TAG="$(date '+%Y%m%d').$GITHUB_RUN_ID" | ||
echo "Pushing to tag $TAG" | ||
./gradlew jib -PtargetJDK=11 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG | ||
./gradlew jib -PtargetJDK=17 -Djib.httpTimeout=120000 -Djib.console=plain -Ptag=$TAG | ||
working-directory: smoke-tests/images/quarkus | ||
|
||
issue: | ||
name: Open issue on failure | ||
needs: publish | ||
runs-on: ubuntu-latest | ||
if: always() | ||
steps: | ||
# run this action to get workflow conclusion | ||
# You can get conclusion by env (env.WORKFLOW_CONCLUSION) | ||
- uses: technote-space/[email protected] | ||
|
||
- uses: actions/[email protected] | ||
with: | ||
fetch-depth: 0 | ||
|
||
- uses: JasonEtco/[email protected] | ||
if: env.WORKFLOW_CONCLUSION == 'failure' # notify only if failure | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
with: | ||
filename: .github/templates/workflow-failed.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1 @@ | ||
/* | ||
* This file was generated by the Gradle 'init' task. | ||
* | ||
* The settings file is used to specify which projects to include in your build. | ||
* | ||
* Detailed information about configuring a multi-project build in Gradle can be found | ||
* in the user manual at https://docs.gradle.org/6.6/userguide/multi_project_builds.html | ||
*/ | ||
|
||
Comment on lines
-1
to
-9
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed this to match the other smoke test |
||
rootProject.name = 'smoke-test-grpc-images' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
buildscript { | ||
dependencies { | ||
classpath("com.google.cloud.tools:jib-quarkus-extension-gradle:0.1.1") | ||
} | ||
} | ||
|
||
plugins { | ||
id "java" | ||
id "io.quarkus" | ||
id "com.google.cloud.tools.jib" version "3.1.4" | ||
} | ||
|
||
group = "io.opentelemetry" | ||
version = "0.0.1-SNAPSHOT" | ||
|
||
repositories { | ||
mavenCentral() | ||
mavenLocal() | ||
} | ||
|
||
dependencies { | ||
implementation enforcedPlatform("io.quarkus.platform:quarkus-bom:2.5.0.Final") | ||
implementation "io.quarkus:quarkus-resteasy" | ||
} | ||
|
||
compileJava { | ||
// Quarkus 2.0+ does not support Java 8 | ||
options.release = 11 | ||
} | ||
|
||
def targetJDK = project.hasProperty("targetJDK") ? project.targetJDK : 11 | ||
|
||
def tag = findProperty("tag") ?: new Date().format("yyyyMMdd.HHmmSS") | ||
|
||
jib { | ||
from.image = "bellsoft/liberica-openjdk-alpine:$targetJDK" | ||
to.image = "ghcr.io/open-telemetry/opentelemetry-java-instrumentation/smoke-test-quarkus:jdk$targetJDK-$tag" | ||
container { | ||
mainClass = 'bogus' // to suppress Jib warning about missing main class | ||
} | ||
pluginExtensions { | ||
pluginExtension { | ||
implementation = 'com.google.cloud.tools.jib.gradle.extension.quarkus.JibQuarkusExtension' | ||
} | ||
} | ||
} | ||
|
||
tasks.jibDockerBuild.dependsOn quarkusBuild |
Binary file not shown.
6 changes: 6 additions & 0 deletions
6
smoke-tests/images/quarkus/gradle/wrapper/gradle-wrapper.properties
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionSha256Sum=9afb3ca688fc12c761a0e9e4321e4d24e977a4a8916c8a768b1fe05ddb4d6b66 | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.1-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is the fix