Fix Quarkus correlation #4883
Merged
Fix Quarkus correlation #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
trask
commented
Dec 13, 2021
| "org.eclipse.jetty.util.thread.ReservedThreadExecutor", | ||
| "org.glassfish.grizzly.threadpool.GrizzlyExecutorService", | ||
| "org.jboss.threads.EnhancedQueueExecutor", |
trask
commented
Dec 13, 2021
Comment on lines
-1
to
-9
| /* | ||
| * This file was generated by the Gradle 'init' task. | ||
| * | ||
| * The settings file is used to specify which projects to include in your build. | ||
| * | ||
| * Detailed information about configuring a multi-project build in Gradle can be found | ||
| * in the user manual at https://docs.gradle.org/6.6/userguide/multi_project_builds.html | ||
| */ | ||
|
|
There was a problem hiding this comment.
removed this to match the other smoke test settings.gradle files
trask
commented
Dec 13, 2021
| Collection<ExportTraceServiceRequest> traces = waitForTraces() | ||
|
|
||
| then: | ||
| countSpansByName(traces, '/hello') == 1 |
There was a problem hiding this comment.
without the fix, the SERVER span name is / b/c the correlation is lost between the SERVER span and the JAX-RS routing instrumentation, so the SERVER span name cannot be updated
anuraaga
approved these changes
Dec 13, 2021
iNikem
approved these changes
Dec 13, 2021
mateuszrzeszutek
approved these changes
Dec 13, 2021
RashmiRam
pushed a commit
to RashmiRam/opentelemetry-auto-instr-java
that referenced
this pull request
May 23, 2022
* Fix Quarkus correlation * Add Quarkus smoke test image * Add Quarkus smoke test * Fix permission on gradlew * Update to gradle 7.3.1 * Fix Jib build * Bump compilation to Java 11 * Better comment * Fix comment placement * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correlation was getting lost between netty/vertx (request) and quarkus/jax-rs (controller).
The fix is one line (I will highlight it with a review comment).
The PR also adds a smoke test image for Quarkus and a (currently ignored) smoke test.
Will send follow-up PR once smoke test image is published to enable the test.
Resolved #2493