Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture MethodRequest in Context to derive Reactor checkpoint #4114

Closed
wants to merge 1 commit into from

Conversation

HaloFour
Copy link
Contributor

Refactors aspect instrumentation so that the request implements a common interface MethodRequest which is added to the Context. The ReactorAsyncOperationEndStrategy can then extract the MethodRequest and use it to get the name of the span in order to create a Reactor checkpoint.

@iNikem
Copy link
Contributor

iNikem commented Nov 1, 2021

@HaloFour do you intend to finish this PR? Or should we close it to cleanup out list of PRs?

@HaloFour
Copy link
Contributor Author

HaloFour commented Nov 1, 2021

@iNikem

I would like to continue this branch but if you'd prefer I can close this PR and resubmit once I clean it up. Same goes for #3751.

@iNikem
Copy link
Contributor

iNikem commented Nov 2, 2021

If you plan to continue working on this, then no problem, let it live :)

@trask
Copy link
Member

trask commented Jun 27, 2022

same for this one

hi @HaloFour! any objection to closing this (just trying to clean up the backlog a little), and you can re-open when you start working on it again? I think if I close it you won't be able to re-open it, but if you close it, I think you will be able to re-open yourself. And of course you can always ping on the closed PR and one of us will re-open it if that fails.

@trask
Copy link
Member

trask commented Oct 23, 2022

Closing, but please ping back if you start working on it again and would like it to be re-opened!

@trask trask closed this Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants