Support multiple subscriptions for Reactor spans #3751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/easycla |
HaloFour
force-pushed
the
reactor-multi-subscription
branch
from
b64c9f6 to
3c473b7
Compare
HaloFour
force-pushed
the
reactor-multi-subscription
branch
from
3c473b7 to
696f8e2
Compare
HaloFour
force-pushed
the
reactor-multi-subscription
branch
from
696f8e2 to
5fe7f0a
Compare
HaloFour
force-pushed
the
reactor-multi-subscription
branch
from
b213055 to
fd5ee0c
Compare
HaloFour
force-pushed
the
reactor-multi-subscription
branch
from
fd5ee0c to
6624968
Compare
|
@HaloFour do you still plan to work on this PR? |
|
Yes, I would like to continue work on this PR, hopefully I have a chance to do so this week. |
|
hi @HaloFour! any objection to closing this (just trying to clean up the backlog a little), and you can re-open when you start working on it again? I think if I close it you won't be able to re-open it, but if you close it, I think you will be able to re-open yourself. And of course you can always ping on the closed PR and one of us will re-open it if that fails. |
|
Closing, but please ping back if you start working on it again and would like it to be re-opened! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explores refactoring the Reactor 3.x async strategy to use an operator instead of composing over the various
doOnSignalmethods. Using an operator provides closer access to the Subscriber/Subscription allowing it to be decorated so that I can intercept each subscription and the signals sent to them.What this would enable is allowing multiple spans to be started/ended for a Reactor publisher, one for the original method call plus one for each subsequent subscription if the publisher is re-used, which can happen accidentally or can be intentional if treated as a Reader/IO monad.
It looks like RxJava 2/3 also support the same approach although it is a bit more involved as there are separate operator/observer interfaces for each of the reactive types.
Discussion: #3753