Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove propagation formats #24

Merged
merged 7 commits into from
Nov 22, 2019
Merged

Remove propagation formats #24

merged 7 commits into from
Nov 22, 2019

Conversation

trask
Copy link
Member

@trask trask commented Nov 22, 2019

See #16

@trask
Copy link
Member Author

trask commented Nov 22, 2019

DataDog propagation format is not removed for now because the tests rely on some form of trace context propagation.

Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you're removing some things that you'll need to add back in later, but I guess that's fine with me. I assume everything in dd-trace-{api,ot} will eventually be deleted

@trask
Copy link
Member Author

trask commented Nov 22, 2019

Thx! Do you mean functionality that will be brought back via OpenTelemetry SDK, or something that we will need to bring back in the agent code itself?

@tylerbenson
Copy link
Member

I think you're right that this functionality will be implemented in the SDK, so carry on.

@trask trask merged commit e6ad427 into open-telemetry:master Nov 22, 2019
@trask trask deleted the remove-propagation-formats branch November 22, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants