Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove functionality that should be delegated to the OpenTelemetry SDK / Exporters #16

Closed
9 tasks done
trask opened this issue Nov 16, 2019 · 3 comments
Closed
9 tasks done
Milestone

Comments

@trask trask added this to the v0.1.0 milestone Nov 18, 2019
@trask
Copy link
Member Author

trask commented Nov 19, 2019

For the Tag decorators, it's not clear to me whether this functionality should eventually be absorbed by the individual instrumentations, or by the SDK / Exporter, or a mix.

So thinking of keeping the tag decorators mostly as is for now.

@trask
Copy link
Member Author

trask commented Dec 3, 2019

I've looked at the decorators in more detail, and ready to go ahead and remove them, absorbing a bit of their functionality into the individual instrumentation where it seems appropriate.

@trask
Copy link
Member Author

trask commented Dec 17, 2019

Closing, I think this issue is completed now! A few more things will fall out as part of #6 (Remove OpenTracing interoperability) and #43 (Change instrumentation to use OpenTelemetry API indirectly).

@trask trask closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant