Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove service name split by tags #20

Merged
merged 2 commits into from
Nov 20, 2019
Merged

Remove service name split by tags #20

merged 2 commits into from
Nov 20, 2019

Conversation

trask
Copy link
Member

@trask trask commented Nov 19, 2019

See #16

@trask trask mentioned this pull request Nov 19, 2019
Closed
9 tasks
jkwatson
jkwatson approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not convinced that the OTel SDK has a very good answer for this stuff yet, but I do agree that it doesn't belong here. :)

@trask trask merged commit 5ad3aea into open-telemetry:master Nov 20, 2019
@trask trask deleted the remove-service-name-split-by-tags branch November 20, 2019 08:11
mateuszrzeszutek referenced this pull request in mateuszrzeszutek/opentelemetry-java-instrumentation Mar 30, 2021
New Instrumenter API - InstrumenterBuilder (#20)
6c5e576 
* New Instrumenter API - InstrumenterBuilder

* New Instrumenter API - InstrumenterBuilder - code review comments
anuraaga pushed a commit that referenced this pull request Apr 5, 2021
New Instrumenter API (#2596)
cc47da5 
* Instrumenter

* Spotless

* More instrumenter

* More

* Instrumenter API

* New Instrumenter API - InstrumenterBuilder (#20)

* New Instrumenter API - InstrumenterBuilder

* New Instrumenter API - InstrumenterBuilder - code review comments

* Start doccing

* Docs

* Most tests

* Last test

* Stick with current hostName lookup for now

* Update testing-common/src/main/groovy/io/opentelemetry/instrumentation/test/base/HttpClientTest.groovy

Co-authored-by: Mateusz Rzeszutek <[email protected]>

* New Instrumenter API - code review comments (#21)

* Doc

* Checkstyle

* Cleanups

Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson jkwatson approved these changes

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

@safris safris Awaiting requested review from safris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trask @jkwatson