-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring starter should support otel.propagators #10408
Spring starter should support otel.propagators #10408
Conversation
683cb83
to
3aa0f05
Compare
@jeanbisutti created a follow up task for docs: #10419 |
Would you mind creating a separate PR for |
681d17d
to
3bd4558
Compare
sure - moved to #10420 |
962884b
to
fa39e7b
Compare
...pentelemetry/instrumentation/spring/autoconfigure/propagators/PropagationPropertiesTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to stop supporting the spring.application.name
property to populate the service name? The two concepts seem to have similar semantics.
|
it looks like there's some overlapping commits between this and #10454? |
Yes, this pr is the base and should be merged first |
...entelemetry/instrumentation/spring/autoconfigure/resources/OtelSpringResourceProperties.java
Outdated
Show resolved
Hide resolved
d2725d7
to
d035717
Compare
Follow up to #10292
Split off:
otel.metric.export.interval
for consistency - moved to use duration parser of config properties for consistency #10512