Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring use sdk autoconfig #10453

Merged
merged 11 commits into from
Mar 13, 2024
Merged

Spring use sdk autoconfig #10453

merged 11 commits into from
Mar 13, 2024

Conversation

zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Feb 9, 2024 •
edited
Loading

Todo

Fixes #10409, fixes #8963, fixes #8962

@zeitlinger zeitlinger self-assigned this Feb 9, 2024
@github-actions github-actions bot requested a review from theletterf February 9, 2024 14:23
@zeitlinger zeitlinger mentioned this pull request Feb 9, 2024
Merged
@zeitlinger zeitlinger mentioned this pull request Feb 19, 2024
Closed
5 tasks
@zeitlinger zeitlinger force-pushed the spring-use-sdk-autoconfig branch 2 times, most recently from bef5128 to 58e1111 Compare February 21, 2024 13:32
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Feb 28, 2024
@zeitlinger zeitlinger force-pushed the spring-use-sdk-autoconfig branch from 9eefc50 to 696ea96 Compare March 11, 2024 10:07
@zeitlinger zeitlinger force-pushed the spring-use-sdk-autoconfig branch from 696ea96 to 977b08d Compare March 11, 2024 10:45
@zeitlinger zeitlinger marked this pull request as ready for review March 11, 2024 10:45
@zeitlinger zeitlinger requested a review from a team March 11, 2024 10:45
@zeitlinger zeitlinger added this to the v2.2.0 milestone Mar 11, 2024
@zeitlinger
Copy link
Member Author

I want to add the functionality of #10754 into the spring starter. This would require a copy of ResourceProviderPropertiesCustomizer.
I think it would make sense to move this class into a new module called sdk-autoconfigure-support.

@laurit wdyt?

@trask
Copy link
Member

trask commented Mar 12, 2024

I want to add the functionality of #10754 into the spring starter. This would require a copy of ResourceProviderPropertiesCustomizer. I think it would make sense to move this class into a new module called sdk-autoconfigure-support.

@laurit wdyt?

can this be done in a separate PR?

@zeitlinger
Copy link
Member Author

I want to add the functionality of #10754 into the spring starter. This would require a copy of ResourceProviderPropertiesCustomizer. I think it would make sense to move this class into a new module called sdk-autoconfigure-support.
@laurit wdyt?

can this be done in a separate PR?

yes, definitely - I'll create a ticket

@zeitlinger
Copy link
Member Author

yes, definitely - I'll create a ticket

#10835

@trask trask merged commit b7e847c into open-telemetry:main Mar 13, 2024
49 checks passed
@zeitlinger zeitlinger deleted the spring-use-sdk-autoconfig branch March 13, 2024 14:51
@trask trask mentioned this pull request Mar 27, 2024
Closed
@zeitlinger zeitlinger mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti approved these changes

@theletterf theletterf Awaiting requested review from theletterf

Assignees

@zeitlinger zeitlinger

Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
No open projects
Spring Boot Starter GA
Status: Done
Milestone
v2.2.0
3 participants
@zeitlinger @trask @jeanbisutti