-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync github actions, including release workflow #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
assigned anuraaga, breedx-splk, cyrille-leclerc, dehaansa, anosek-an, iNikem, jack-berg, kenfinnigan, kittylyst and ghost
Mar 26, 2022
github-actions
bot
requested review from
anuraaga,
breedx-splk,
cyrille-leclerc,
dehaansa,
anosek-an,
iNikem,
jack-berg,
kenfinnigan,
kittylyst,
a user,
Mrod1598,
rmfitzpatrick and
willarmiros
March 26, 2022 20:27
trask
force-pushed
the
sync-github-actions
branch
from
March 26, 2022 20:37
9e20dde
to
87e397c
Compare
This was referenced Mar 26, 2022
trask
changed the title
Sync github actions, other than release actions
Sync github actions, including release workflow
Mar 27, 2022
mateuszrzeszutek
approved these changes
Mar 29, 2022
Merged
jkschulz
added a commit
to GoogleCloudPlatform/ops-agent
that referenced
this pull request
May 31, 2022
#607 included changes that altered build flags for gradle because of an [upstream change](open-telemetry/opentelemetry-java-contrib#274) -- unclear whether this was necessary for the purpose of the PR or not (to add a metrics receiver for Jetty). These changes were only made for the Linux build, but not Windows, breaking the Windows builds. See https://github.com/GoogleCloudPlatform/ops-agent/pull/607/files#r880772695 Fixes http://b/234486247
jkschulz
added a commit
to GoogleCloudPlatform/ops-agent
that referenced
this pull request
Jun 1, 2022
#607 included changes that altered build flags for gradle because of an [upstream change](open-telemetry/opentelemetry-java-contrib#274) -- unclear whether this was necessary for the purpose of the PR or not (to add a metrics receiver for Jetty). These changes were only made for the Linux build, but not Windows, breaking the Windows builds. See https://github.com/GoogleCloudPlatform/ops-agent/pull/607/files#r880772695
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also open-telemetry/opentelemetry-java-instrumentation#5695 and open-telemetry/opentelemetry-java#4311.