Update Dockerfile.windows with changes missed in #607. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#607 included changes that altered build flags for gradle because of an [upstream change](open-telemetry/opentelemetry-java-contrib#274) -- unclear whether this was necessary for the purpose of the PR or not (to add a metrics receiver for Jetty). These changes were only made for the Linux build, but not Windows, breaking the Windows builds. See https://github.com/GoogleCloudPlatform/ops-agent/pull/607/files#r880772695 Fixes http://b/234486247
igorpeshansky
approved these changes
May 31, 2022
|
windows build passed! http://b/234486247#comment5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#607 included changes that altered build flags for gradle because of an upstream change -- unclear whether this was necessary for the purpose of the PR or not (to add a metrics receiver for Jetty). These changes were only made for the Linux build, but not Windows, breaking the Windows builds.
See https://github.com/GoogleCloudPlatform/ops-agent/pull/607/files#r880772695
Fixes http://b/234486247