-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow dropping items from correlations + docs + cleanups #454
Merged
Commits on Feb 3, 2020
-
Drop entry from correlation map
Entry used to contain stuff like TTL, but right now the notion of entry was dropped from the spec.
Configuration menu - View commit details
-
Copy full SHA for 7f7152e - Browse repository at this point
Copy the full SHA 7f7152eView commit details -
Compute exact size of the correlations map
The map will be immutable, so spend some more time to ensure that we will not unnecessarily waste some memory on a basically read-only map.
Configuration menu - View commit details
-
Copy full SHA for f03573a - Browse repository at this point
Copy the full SHA f03573aView commit details -
Allow dropping keys from correlations map
This is to follow the spec. Before this change it was possible in an awkward way by using Foreach to gather and filter the key-value pairs, and then calling NewMap with a MultiKV MapUpdate.
Configuration menu - View commit details
-
Copy full SHA for bbcec28 - Browse repository at this point
Copy the full SHA bbcec28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4556682 - Browse repository at this point
Copy the full SHA 4556682View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e50ebc - Browse repository at this point
Copy the full SHA 2e50ebcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7100354 - Browse repository at this point
Copy the full SHA 7100354View commit details -
Factor out getting map size and test it
This is an implementation detail that can't be tested in a black-box manner.
Configuration menu - View commit details
-
Copy full SHA for c20444d - Browse repository at this point
Copy the full SHA c20444dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 883149d - Browse repository at this point
Copy the full SHA 883149dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae01b00 - Browse repository at this point
Copy the full SHA ae01b00View commit details -
Configuration menu - View commit details
-
Copy full SHA for a072ddc - Browse repository at this point
Copy the full SHA a072ddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 719ef91 - Browse repository at this point
Copy the full SHA 719ef91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e8c0d3 - Browse repository at this point
Copy the full SHA 6e8c0d3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.