Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dropping items from correlations + docs + cleanups #454

Merged
merged 12 commits into from
Feb 3, 2020
Merged

Allow dropping items from correlations + docs + cleanups #454

merged 12 commits into from
Feb 3, 2020

Commits on Feb 3, 2020

  1. Drop entry from correlation map 

    Entry used to contain stuff like TTL, but right now the notion of
entry was dropped from the spec.
    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    7f7152e View commit details
    Browse the repository at this point in the history

  2. Compute exact size of the correlations map 

    The map will be immutable, so spend some more time to ensure that we
will not unnecessarily waste some memory on a basically read-only map.
    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    f03573a View commit details
    Browse the repository at this point in the history

  3. Allow dropping keys from correlations map 

    This is to follow the spec. Before this change it was possible in an
awkward way by using Foreach to gather and filter the key-value pairs,
and then calling NewMap with a MultiKV MapUpdate.
    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    bbcec28 View commit details
    Browse the repository at this point in the history

  4. Document the correlation package

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    4556682 View commit details
    Browse the repository at this point in the history

  5. Add missing license blurbs in correlation package

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    2e50ebc View commit details
    Browse the repository at this point in the history

  6. Add tests for deleting items in correlations

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    7100354 View commit details
    Browse the repository at this point in the history

  7. Factor out getting map size and test it 

    This is an implementation detail that can't be tested in a black-box
manner.
    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    c20444d View commit details
    Browse the repository at this point in the history

  8. Fix copyright dates

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    883149d View commit details
    Browse the repository at this point in the history

  9. Simplify/disambiguate keySet function parameters/return values

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    ae01b00 View commit details
    Browse the repository at this point in the history

  10. Fix typo in Apply docs

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    a072ddc View commit details
    Browse the repository at this point in the history

  11. Fix test names

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    719ef91 View commit details
    Browse the repository at this point in the history

  12. Explain the nonsense of dropping keys from new map

    @krnowak
    krnowak committed Feb 3, 2020
    Configuration menu
    Copy the full SHA
    6e8c0d3 View commit details
    Browse the repository at this point in the history