Allow dropping items from correlations + docs + cleanups #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
iredelmeier,
jmacd,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
rghetia
reviewed
Jan 31, 2020
krnowak
force-pushed
the
krnowak/correlation
branch
from
316c0ef to
c8d4141
Compare
|
Rebased and updated. |
MrAlias
approved these changes
Feb 3, 2020
|
@krnowak please rebase one more time. I'll merge this before any other PR ;-) |
rghetia
approved these changes
Feb 3, 2020
Entry used to contain stuff like TTL, but right now the notion of entry was dropped from the spec.
The map will be immutable, so spend some more time to ensure that we will not unnecessarily waste some memory on a basically read-only map.
This is to follow the spec. Before this change it was possible in an awkward way by using Foreach to gather and filter the key-value pairs, and then calling NewMap with a MultiKV MapUpdate.
This is an implementation detail that can't be tested in a black-box manner.
krnowak
force-pushed
the
krnowak/correlation
branch
from
c8d4141 to
6e8c0d3
Compare
|
@rghetia : Rebased. :) |
MrAlias
approved these changes
Feb 3, 2020
jmacd
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things in correlations package:
core.Valuedirectly.