Adds Histogram Aggregator #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paivagustavo
added
pkg:SDK
paivagustavo
requested review from
iredelmeier,
jmacd,
lizthegrey,
rghetia and
tedsuo
as code owners
rghetia
reviewed
Jan 16, 2020
rghetia
reviewed
Jan 16, 2020
MrAlias
reviewed
Jan 17, 2020
Change to less-than buckets. Add offset checks. Unexport fields that don't need to be exported. Fix tests when running on profile with int64 number kind.
|
I've addressed all the discussions, thanks everyone :) |
MrAlias
approved these changes
Jan 20, 2020
rghetia
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new Aggregator implementation
Histogram.Fixes #317
It returns a
Bucketswhich consists of the bucket's boundaries and the counts for each bucket. These counts are not cumulative, the reason for this is to make the update simpler and faster. Exporters may accumulate them if needed.