Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Histogram aggregator #317

Closed
jmacd opened this issue Nov 14, 2019 · 2 comments · Fixed by #433
Closed

Implement Histogram aggregator #317

jmacd opened this issue Nov 14, 2019 · 2 comments · Fixed by #433
Assignees
@paivagustavo
Labels
area:metrics Part of OpenTelemetry Metrics
Milestone
untracked

Comments

@jmacd
Copy link
Contributor

jmacd commented Nov 14, 2019

The metics export pipeline has support for configurable aggregators. In the SDK specification (WIP), open-telemetry/opentelemetry-specification#347, four aggregators are specified that SHOULD be provided to support measure metric instruments. One is currently missing from this set, the Histogram aggregator. This aggregator should (probably) support both exponential bucket sizes and linear bucket sizes.
@paivagustavo paivagustavo mentioned this issue Dec 4, 2019
Closed
@rghetia rghetia added the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Dec 5, 2019
@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Dec 12, 2019
@jmacd
Copy link
Contributor Author

jmacd commented Dec 12, 2019

I'm not sure if this is blocked on the spec or not. We've settled the issue about TimeSeries representation in the protocol,
open-telemetry/opentelemetry-proto#54
so I'm marking this as unblocked.

The basic Histogram Aggregator will be similar to the other Measure-kind of aggregators (DDSketch, Array, MinMaxSumCount) but will support configurable (and default) bucket ranges. The protocol supports declaring a variety of bucket-range options, probably those should be mirrored in the Histogram aggregator.

@paivagustavo paivagustavo mentioned this issue Dec 13, 2019
Merged
@jmacd jmacd removed the blocked:specification Waiting on clarification of the OpenTelemetry specification before progress can be made label Dec 19, 2019
@paivagustavo
Copy link
Member

I've been working on this.

@paivagustavo paivagustavo self-assigned this Jan 14, 2020
@paivagustavo paivagustavo mentioned this issue Jan 16, 2020
Merged
@paivagustavo paivagustavo mentioned this issue Feb 18, 2020
Closed
hstan referenced this issue in hstan/opentelemetry-go Oct 15, 2020
@dependabot @MrAlias
Bump github.com/labstack/echo/v4 from 4.1.16 to 4.1.17 in /instrument…
dc7145c 
…ation/github.com/labstack/echo (#317)

* Bump github.com/labstack/echo/v4

Bumps [github.com/labstack/echo/v4](https://github.com/labstack/echo) from 4.1.16 to 4.1.17.
- [Release notes](https://github.com/labstack/echo/releases)
- [Commits](labstack/echo@v4.1.16...v4.1.17)

Signed-off-by: dependabot[bot] <[email protected]>

* Auto-fix go.sum changes in dependent modules

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Yahn <[email protected]>
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paivagustavo paivagustavo

Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Milestone
untracked
Development

Successfully merging a pull request may close this issue.

Adds Histogram Aggregator
4 participants
@jmacd @pellared @paivagustavo @rghetia