Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semconv/v1.20.0 #4078

Merged
merged 9 commits into from
May 16, 2023
Merged

Add semconv/v1.20.0 #4078

merged 9 commits into from
May 16, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented May 9, 2023

Fixes #3988

The changes in httpconv are related to open-telemetry/opentelemetry-specification#3272

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #4078 (1ba7e09) into main (fadd3d6) will increase coverage by 0.5%.
The diff coverage is 100.0%.

❗ Current head 1ba7e09 differs from pull request most recent head 9ae7384. Consider uploading reports for the commit 9ae7384 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4078     +/-   ##
=======================================
+ Coverage   82.7%   83.3%   +0.5%     
=======================================
  Files        179     181      +2     
  Lines      13498   13934    +436     
=======================================
+ Hits       11176   11616    +440     
+ Misses      2101    2097      -4     
  Partials     221     221             
Impacted Files Coverage Δ
semconv/internal/v4/http.go 100.0% <100.0%> (ø)
semconv/internal/v4/net.go 100.0% <100.0%> (ø)

... and 2 files with indirect coverage changes

@pellared pellared marked this pull request as ready for review May 9, 2023 12:51
RELEASING.md Show resolved Hide resolved
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the main differences between internal/v3 and internal/v4?

CHANGELOG.md Outdated Show resolved Hide resolved
@pellared
Copy link
Member Author

What are the main differences between internal/v3 and internal/v4?

Changes related to open-telemetry/opentelemetry-specification#3272

Co-authored-by: Tyler Yahn <[email protected]>
@MrAlias MrAlias merged commit 8445f21 into open-telemetry:main May 16, 2023
@pellared pellared deleted the semconv-v1.20.0 branch May 17, 2023 06:37
@XSAM XSAM added this to the Old Untracked PRs milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate v1.20.0 semconv
6 participants