Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force worktree add #301

Closed
wants to merge 5 commits into from
Closed

Conversation

unicod3
Copy link

@unicod3 unicod3 commented Apr 22, 2023

Resolves #41

I also came upon this issue while playing with the semconvgen package and tried to patch it.

More on the -f param:
https://git-scm.com/docs/git-worktree#Documentation/git-worktree.txt---force

@unicod3 unicod3 requested review from a team and codeboten April 22, 2023 19:43
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (653d34f) 58.99% compared to head (a56ab90) 58.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #301   +/-   ##
=======================================
  Coverage   58.99%   58.99%           
=======================================
  Files          46       46           
  Lines        2024     2024           
=======================================
  Hits         1194     1194           
  Misses        698      698           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry.

pellared
pellared previously approved these changes Apr 24, 2023
@pellared
Copy link
Member

pellared commented May 9, 2023

@unicod3 I am not sure it if is needed. I guess I encountered the same issue here: open-telemetry/opentelemetry-go#4078 (comment)

I am not sure if -f does always what we want:

[...] if is already assigned to some worktree but is missing (for instance, if was deleted manually). This option overrides these safeguards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semconvgen: panic: unable to exe when specification version is set
3 participants