[#396] Remove http.request span in httptrace #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huikang
requested review from
iredelmeier,
jmacd,
lizthegrey,
paivagustavo,
rghetia and
tedsuo
as code owners
huikang
force-pushed
the
fix-missing-span-end
branch
2 times, most recently
from
b03de94 to
b8b8b0c
Compare
jmacd
approved these changes
Dec 23, 2019
paivagustavo
suggested changes
Dec 23, 2019
huikang
force-pushed
the
fix-missing-span-end
branch
from
b8b8b0c to
5580980
Compare
|
Please update the PR title / description. |
Signed-off-by: Hui Kang <[email protected]>
huikang
force-pushed
the
fix-missing-span-end
branch
from
0c436c7 to
019f0dd
Compare
huikang
changed the title
Done. Thanks. |
|
Thank you! |
|
fixes #396 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hui Kang [email protected]