[#396] Fix missing span end in httptrace

Signed-off-by: Hui Kang <[email protected]>
open-telemetry · Dec 23, 2019 · 5580980 · 5580980
1 parent 99cb01b
commit 5580980
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/plugin/httptrace/clienttrace.go b/plugin/httptrace/clienttrace.go
@@ -56,6 +56,7 @@ func NewClientTrace(ctx context.Context) *httptrace.ClientTrace {
 
 	ct.tr = global.TraceProvider().Tracer("go.opentelemetry.io/otel/plugin/httptrace")
 	ct.start("http.request", "http.request")
+	defer ct.end("http.request", nil)
 
 	return &httptrace.ClientTrace{
 		GetConn:              ct.getConn,

diff --git a/plugin/httptrace/clienttrace_test.go b/plugin/httptrace/clienttrace_test.go
@@ -104,6 +104,9 @@ func TestHTTPRequestWithClientTrace(t *testing.T) {
 		{
 			name: "go.opentelemetry.io/otel/plugin/httptrace/http.receive",
 		},
+		{
+			name: "go.opentelemetry.io/otel/plugin/httptrace/http.request",
+		},
 		{
 			name: "go.opentelemetry.io/otel/plugin/httptrace/http.send",
 		},
-Original file line number
+Diff line change
@@ Expand Up / @@ -104,6 +104,9 @@ func TestHTTPRequestWithClientTrace(t *testing.T) { @@
     		{
     			name: "go.opentelemetry.io/otel/plugin/httptrace/http.receive",
     		},
+    		{
+    			name: "go.opentelemetry.io/otel/plugin/httptrace/http.request",
+    		},
     		{
     			name: "go.opentelemetry.io/otel/plugin/httptrace/http.send",
     		},
@@ Expand Down @@