-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Context Propagation @ OTEP 66 #381
Conversation
There are still some correctness issues here and the confusion discussed in open-telemetry/oteps#68 is real. We have both a SpanContext and a Span in the context.Context and it's not clear this is what we want. Presently the "current" SpanContext and Span are lacking coordination, so the |
This PR removes the non-compliant |
FYI this PR is a bit difficult to review because it mixes refactoring with several API changes. To really merge this properly it should be split into several steps. |
FYI the OpenTracing bridge is broken by this PR. It will take more work. |
…#381) * Examples into separate modules - Create separate go.mod for intrumentation examples - Update and clean-up go.mod files for instrumentation - Use replace directive to on-disk location where appropriate * Remove SDK from metric tests - replace SDK with internal trace test helper package * Update dependabot config * Update gitignore to exclude example binaries * Update CHANGELOG.md * PR feedback - include additional replace directives - Include missing replace directives in example go.mod files
This implements a proof of concept for the proposal in OTEP 66.
The new API
Propagators
API is found in:api/context/propagation
The new global
Propagators
is added to api/global.These new packages are refactored from existing propagators:
api/trace/propagation
api/context/baggage/propagation
This has been prepared to support OTEP 66, as such it is not in ready-to-merge form. Several new tests should be introduced for the new functionality introduced.