Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on external W3C propagation library #391

Closed
jmacd opened this issue Dec 19, 2019 · 9 comments
Closed

Depend on external W3C propagation library #391

jmacd opened this issue Dec 19, 2019 · 9 comments
Labels
area:propagators Part of OpenTelemetry context propagation
Milestone

Comments

@jmacd
Copy link
Contributor

jmacd commented Dec 19, 2019

The proposal is to replace the implementation of the W3C traceparent context to use code from https://github.com/lightstep/tracecontext.go, which would be copied into a new OpenTelemetry- or W3C-organized GitHub repository. The primary motivation is -- that implementation includes tracestate support.

The existing Correlation-Context support implemented in this repository would be separately copied into the repository introduced above, to complete the set of W3C propagators in one location. After #381, the existing Correlation-Context half becomes the baggage propagator, so the two parts will have been pre-factored.

(cc @iredelmeier @sjkaris)

@jmacd
Copy link
Contributor Author

jmacd commented Jan 2, 2020

Action item: reach out to W3C team and get a new repo? If not, we'll create a repo in the OTel org. @mwear who should we ask about getting a new repo created in the W3C github org?

@mwear
Copy link
Member

mwear commented Jan 2, 2020

@SergeyKanzhelev do you think this belongs in the W3C Github org, and if so, can you help create a repository for it?

@MrAlias
Copy link
Contributor

MrAlias commented Jan 15, 2020

One thing that was pointed out to me by a few members of the Distributed Tracing W3C working group is that the W3C is a standards body and they didn't know of any other instances (off-hand at least) where the W3C hosted implementations of the specifications. That being said, I'm still interested to hear what @SergeyKanzhelev has to say about the subject.

@jmacd
Copy link
Contributor Author

jmacd commented May 26, 2020

Update: https://github.com/lightstep/tracecontext.go is being made private, the same code is available https://github.com/iredelmeier/tracecontext.go

@MrAlias
Copy link
Contributor

MrAlias commented Aug 24, 2020

This should probably act as a superset of #75

@MrAlias MrAlias added priority:p2 area:propagators Part of OpenTelemetry context propagation labels Aug 24, 2020
@MrAlias
Copy link
Contributor

MrAlias commented Aug 24, 2020

At this point, I propose to resolve this issue by consolidating a complete and documented W3C propagation library here in this repo that this project can use. The package should be kept internal and if there is demand we can then move it to an external repo or expose it here.

@SergeyKanzhelev
Copy link
Member

@SergeyKanzhelev do you think this belongs in the W3C Github org, and if so, can you help create a repository for it?

I doubt we will have any engineering force behind the W3C to support it.

@MrAlias MrAlias added this to the RC1 milestone Aug 27, 2020
@MrAlias MrAlias removed this from the RC1 milestone Feb 16, 2021
@MadVikingGod
Copy link
Contributor

It look like W3C doesn't have a library that we could rely on. It also doesn't seem apparent that we could incorporate it now with 1.0 being out.

I think we should close this as won't do.

@MrAlias
Copy link
Contributor

MrAlias commented Nov 15, 2021

It look like W3C doesn't have a library that we could rely on. It also doesn't seem apparent that we could incorporate it now with 1.0 being out.

I think we should close this as won't do.

Agreed.

@MrAlias MrAlias closed this as completed Nov 15, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:propagators Part of OpenTelemetry context propagation
Projects
None yet
Development

No branches or pull requests

6 participants