Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure compatibility testing #3779

Merged
merged 8 commits into from
Feb 27, 2023
Merged

Restructure compatibility testing #3779

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9c6f1ce
Restructure compatibility testing
unicod3 Feb 26, 2023
5562ab8
Add PR number into Changelog
unicod3 Feb 26, 2023
8488595
Keep the original name for compatibility matrix
unicod3 Feb 26, 2023
4baf0c9
Remove changelog entry
unicod3 Feb 26, 2023
e240fc6
Merge branch 'main' into restructure-compatibility-test
hanyuancheung Feb 27, 2023
2227a5c
Apply suggestions
unicod3 Feb 27, 2023
bcf21ff
Merge branch 'main' into restructure-compatibility-test
MrAlias Feb 27, 2023
a2a34dd
Merge branch 'main' into restructure-compatibility-test
MrAlias Feb 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
name: opentelemetry-go-test-output
path: ${{ env.TEST_RESULTS }}

compatibility-test:
compatibility-matrix:
unicod3 marked this conversation as resolved.
Show resolved Hide resolved
strategy:
matrix:
go-version: ["1.20", 1.19, 1.18]
Expand Down Expand Up @@ -150,3 +150,19 @@ jobs:
env:
GOARCH: ${{ matrix.arch }}
run: make test-short

test-compatibility:
runs-on: ubuntu-latest
needs: [compatibility-matrix]
steps:
- name: Print result
run: echo ${{ needs.compatibility-matrix.result }}
- name: Interpret result
run: |
if [[ success == ${{ needs.compatibility-matrix.result }} ]]
then
echo "All matrix jobs passed!"
else
echo "One or more matrix jobs failed."
false
fi
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- [bridge/ot] Fall-back to TextMap carrier when it's not ot.HttpHeaders. (#3679)
- The `Collect` method of the `"go.opentelemetry.io/otel/sdk/metric".Reader` interface is updated to accept the `metricdata.ResourceMetrics` value the collection will be made into. This change is made to enable memory reuse by SDK users. (#3732)
- Restructure compatibility testing. (#3779)

### Fixed

Expand Down