-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure compatibility testing #3779
Restructure compatibility testing #3779
Conversation
|
I'm not sure this requires a changelog entry. |
Agreed, I wasn't sure either tbh, removed it from PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit comment (with proposed changed)
Thanks for contribution.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3779 +/- ##
=======================================
- Coverage 81.6% 81.6% -0.1%
=======================================
Files 167 167
Lines 12453 12453
=======================================
- Hits 10173 10171 -2
- Misses 2065 2067 +2
Partials 215 215
|
Resolves #3768
Hello, this is my first contribution to this repo so tried to tackle this good first issue.
I've restructured the compatibility tests accordingly to what was discussed in last week's meeting (2023-02-23).
Also renamed the token job's name to
test-compatibility
so it is aligned with other test jobs.You can see it in action in the link below:
https://github.com/unicod3/opentelemetry-go/actions/runs/4272402129/jobs/7437568975
Please let me know if I missed anything.