Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new env config options for OTLP exporter #3363

Merged
merged 13 commits into from
Nov 8, 2022
Prev Previous commit
Next Next commit
error path
seankhliao committed Oct 19, 2022

Verified

This commit was signed with the committer’s verified signature.
seankhliao Sean Liao
commit b4bcc9120f86b1e5c8930c6a4ec964f64aa0721d
3 changes: 2 additions & 1 deletion exporters/otlp/internal/envconfig/envconfig_test.go
Original file line number Diff line number Diff line change
@@ -17,6 +17,7 @@ package envconfig // import "go.opentelemetry.io/otel/exporters/otlp/internal/en
import (
"crypto/tls"
"crypto/x509"
"errors"
"net/url"
"testing"
"time"
@@ -387,7 +388,7 @@ func TestWithClientCert(t *testing.T) {
)
assert.Equal(t, cert, option.TestTLS.Certificates[0])

reader.ReadFile = func(s string) ([]byte, error) { return []byte{}, nil }
reader.ReadFile = func(s string) ([]byte, error) { return nil, errors.New("oops") }
option.TestTLS = nil
reader.Apply(
WithClientCert("CLIENT_CERTIFICATE", "CLIENT_KEY", func(c tls.Certificate) {