-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new env config options for OTLP exporter #3363
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
=======================================
- Coverage 77.8% 77.7% -0.1%
=======================================
Files 164 164
Lines 11497 11572 +75
=======================================
+ Hits 8945 8992 +47
- Misses 2349 2373 +24
- Partials 203 207 +4
|
not sure what to do with coverage as the other places i modified don't seem to have tests in place |
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Seems the changelog has conflicts, please resolve them. |
resolved |
@Aneurysm9 does this look good to you? |
spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options
Add the
INSECURE
CLIENT_CERTIFICATE
andCLIENT_KEY
env options for the otlp exporters