Use /usr/bin/env bash rather than /bin/bash #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_main_pkgs.sh uses 'mapfile' which is not available in Bash versions earlier than 4.x. On machines where the default installed bash is 3.x (OSX), this causes `make precommit` to break. However, it's easy enough to install a recent version of bash (e.g. via homebrew) in `/usr/local/bin/bash`. With `/usr/local/bin` in your path, and `/usr/bin/env bash` as the shebang line, this enables `make precommit` to pass with flying colors.
evantorrie
requested review from
jmacd,
lizthegrey,
pjanotti,
rghetia,
sjkaris and
tedsuo
as code owners
jmacd
approved these changes
Nov 21, 2019
|
This is needed and not controversial. |
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
* Update configure() to newConfig() per new style guide * Update gocql newConfig to reflect correct type it initializes Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_main_pkgs.sh uses 'mapfile' which is not available in Bash
versions earlier than 4.x. On machines where the default installed
bash is 3.x (OSX), this causes
make precommitto break.However, it's easy enough to install a recent version of
bash (e.g. via homebrew) in
/usr/local/bin/bash. With/usr/local/binin your path, and/usr/bin/env bashas the shebangline, this enables
make precommitto pass with flying colors.