Skip to content

Commit

Permalink
Use /usr/bin/env bash rather than /bin/bash (#336)
Browse files Browse the repository at this point in the history
get_main_pkgs.sh uses 'mapfile' which is not available in Bash
versions earlier than 4.x. On machines where the default installed
bash is 3.x (OSX), this causes `make precommit` to break.

However, it's easy enough to install a recent version of
bash (e.g. via homebrew) in `/usr/local/bin/bash`. With
`/usr/local/bin` in your path, and `/usr/bin/env bash` as the shebang
line, this enables `make precommit` to pass with flying colors.
  • Loading branch information
evantorrie authored and jmacd committed Nov 22, 2019
1 parent 2c437c9 commit 6b63281
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion get_main_pkgs.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

set -euo pipefail

Expand Down

0 comments on commit 6b63281

Please sign in to comment.