-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[console] Support ActivitySource.Tags #5935
[console] Support ActivitySource.Tags #5935
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5935 +/- ##
==========================================
+ Coverage 83.38% 86.40% +3.02%
==========================================
Files 297 261 -36
Lines 12531 11616 -915
==========================================
- Hits 10449 10037 -412
+ Misses 2082 1579 -503
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
left a small suggestion.
Relates to #5701
Changes
ActivitySource.Tags
(if set) when exporting traces to console.Examples
Traces:
Metrics (tweaked):
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes