Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support .NET 9 ActivitySource Tags #5701

Closed
CodeBlanch opened this issue Jun 18, 2024 · 3 comments
Closed

Support .NET 9 ActivitySource Tags #5701

CodeBlanch opened this issue Jun 18, 2024 · 3 comments
Assignees
@rajkumar-rangaraj
Labels
needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package traces Tracing signal related
Milestone
1.10.0

Comments

@CodeBlanch
Copy link
Member

CodeBlanch commented Jun 18, 2024 •
edited
Loading

.NET 9 is adding support for setting static tags on an ActivitySource: dotnet/runtime#93795

This issue is for tracking support for sending those as instrumentation scope tags when exported via Otlp, Console, & Zipkin (need to figure out if there is a good spot for them).
@CodeBlanch CodeBlanch added the question Further information is requested label Jun 18, 2024
@CodeBlanch CodeBlanch added this to the 1.10.0 milestone Jun 18, 2024
@CodeBlanch CodeBlanch added pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package traces Tracing signal related and removed question Further information is requested labels Jun 18, 2024
@Kielek
Copy link
Contributor

Kielek commented Jun 19, 2024

@CodeBlanch, whats about other exporters?
It wil lbe great to cover at least Console (and zipkin if possible). Should I create separate issue for this or we can track everything here?

@CodeBlanch CodeBlanch added pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package labels Jun 19, 2024
@CodeBlanch
Copy link
Member Author

@Kielek I updated the description. But feel free to create individual issues if you want. This was more for just tracking things being added in .NET 9 we need to look at.

@cijothomas cijothomas mentioned this issue Sep 24, 2024
Closed
@rajkumar-rangaraj rajkumar-rangaraj mentioned this issue Oct 10, 2024
Merged
4 tasks
@CodeBlanch CodeBlanch mentioned this issue Oct 16, 2024
Closed
This was referenced Oct 29, 2024
Merged
Open
@CodeBlanch
Copy link
Member Author

We discussed this on the SIG today. Opened #5935 for Console. Some questions about what to do for Zipkin, opened a dedicated issue to track that: #5936

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rajkumar-rangaraj rajkumar-rangaraj

Labels
needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package pkg:OpenTelemetry.Exporter.Zipkin Issues related to OpenTelemetry.Exporter.Zipkin NuGet package traces Tracing signal related
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
3 participants
@Kielek @rajkumar-rangaraj @CodeBlanch