-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otlp] Nullable annotations for the OtlpExporterOptions class and some xml doc improvement #5434
Merged
CodeBlanch
merged 9 commits into
open-telemetry:main
from
CodeBlanch:otlp-options-nullable-decoration
Mar 11, 2024
Merged
[otlp] Nullable annotations for the OtlpExporterOptions class and some xml doc improvement #5434
CodeBlanch
merged 9 commits into
open-telemetry:main
from
CodeBlanch:otlp-options-nullable-decoration
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
added
the
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
label
Mar 11, 2024
utpilla
reviewed
Mar 11, 2024
utpilla
reviewed
Mar 11, 2024
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Mar 11, 2024
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5434 +/- ##
==========================================
+ Coverage 83.38% 84.89% +1.50%
==========================================
Files 297 279 -18
Lines 12531 11556 -975
==========================================
- Hits 10449 9810 -639
+ Misses 2082 1746 -336
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vishweshbankwar
approved these changes
Mar 11, 2024
rajkumar-rangaraj
approved these changes
Mar 11, 2024
utpilla
approved these changes
Mar 11, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Originally part of #5400]
Changes
OtlpExporterOptions
classMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes