Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otlp] Nullable annotations for the OtlpExporterOptions class and some xml doc improvement #5434

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 11, 2024

[Originally part of #5400]

Changes

  • Add nullable annotations for the OtlpExporterOptions class
  • Tweaks some of the XML docs for clarity

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Mar 11, 2024
@CodeBlanch CodeBlanch requested a review from a team March 11, 2024 19:16
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (6250307) to head (82951f8).
Report is 125 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5434      +/-   ##
==========================================
+ Coverage   83.38%   84.89%   +1.50%     
==========================================
  Files         297      279      -18     
  Lines       12531    11556     -975     
==========================================
- Hits        10449     9810     -639     
+ Misses       2082     1746     -336     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.90% <100.00%> (?)
unittests-Solution-Stable 84.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 97.05% <100.00%> (+0.69%) ⬆️
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 71.06% <100.00%> (ø)

... and 80 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit adc89d9 into open-telemetry:main Mar 11, 2024
33 checks passed
@CodeBlanch CodeBlanch deleted the otlp-options-nullable-decoration branch March 11, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants