-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk-metrics] Improve exemplar tests #5393
[sdk-metrics] Improve exemplar tests #5393
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5393 +/- ##
==========================================
- Coverage 83.38% 83.14% -0.25%
==========================================
Files 297 284 -13
Lines 12531 12070 -461
==========================================
- Hits 10449 10035 -414
+ Misses 2082 2035 -47
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the cumulative testing targeting the spec question! open-telemetry/opentelemetry-specification#3891
Very helpful.
[Originally part of #5364]
Changes
ExemplarReservoir
factory on view API.Merge requirement checklist