Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exemplar - expose ExemplarReservoir and enable View based config #5334

Closed
cijothomas opened this issue Feb 9, 2024 · 2 comments
Closed

Exemplar - expose ExemplarReservoir and enable View based config #5334

cijothomas opened this issue Feb 9, 2024 · 2 comments
Assignees
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-specification/pull/3820/files has clarified the config story for Reservoirs.
Though we have Reservoirs, it was neither public nor configurable via View. This issue is opened to track these changes.

(There is non-trivial amount of work, especially for Histogram case, where we want to avoid finding bucket twice, and there is no easy way to achieve that without help from spec... While implementing this, see if spec needs alternation, or spec is not prohibiting what we do.)

@cijothomas cijothomas added the metrics Metrics signal related label Feb 9, 2024
@CodeBlanch
Copy link
Member

We have internal support now for setting reservoir via view added on: #5393

More work needs to be done before we can expose things as public just capturing this for tracking.

@CodeBlanch CodeBlanch added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Mar 13, 2024
@CodeBlanch
Copy link
Member

Resolved by #5542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

No branches or pull requests

3 participants