Add grpc instrumentation with experimental feature flag #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5130 +/- ##
==========================================
+ Coverage 83.05% 83.32% +0.27%
==========================================
Files 297 297
Lines 12369 12380 +11
==========================================
+ Hits 10273 10316 +43
+ Misses 2096 2064 -32
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Great step forward, and honestly I think this might be a really good approach in general for other changes. |
|
One note I have is that this should also apply to the .HTTP client right? |
For grpc client, there is a separate instrumentation library. https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/src/OpenTelemetry.Instrumentation.GrpcNetClient |
utpilla
reviewed
Dec 6, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreTraceInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Dec 6, 2023
utpilla
reviewed
Dec 6, 2023
utpilla
reviewed
Dec 6, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/AspNetCoreTraceInstrumentationOptions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Dec 6, 2023
CodeBlanch
reviewed
Dec 6, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Dec 6, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/OpenTelemetry.Instrumentation.AspNetCore.csproj
Show resolved
Hide resolved
utpilla
reviewed
Dec 6, 2023
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Dec 6, 2023
| [InlineData("false")] | ||
| [InlineData("True")] | ||
| [InlineData("False")] | ||
| public void GrpcAspNetCoreInstrumentationAddsCorrectAttributesWhenItCreatesNewActivity(string enableGrpcAspNetCoreSupport) |
There was a problem hiding this comment.
Not related to this PR but these tests should be moved to OpenTelemetry.Instrumentation.AspNetCore.Tests.
utpilla
approved these changes
Dec 6, 2023
…ps://github.com/vishweshbankwar/opentelemetry-dotnet into vibankwa/re-introduce-grpc-support-experimental
alanwest
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes