Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric instrumentation for GrpcClient #1748

Open
cijothomas opened this issue Nov 2, 2021 · 1 comment
Open

Metric instrumentation for GrpcClient #1748

cijothomas opened this issue Nov 2, 2021 · 1 comment
Labels
comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient enhancement New feature or request

Comments

@cijothomas
Copy link
Member

Similar to: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInMetricsListener.cs

The instrumentations are not stable release anyway, so we can make changes as spec evolves. The goal is to get some metrics flowing automatically for libraries which already have traces enabled.
@cijothomas cijothomas added the enhancement New feature or request label Nov 2, 2021
@cijothomas cijothomas mentioned this issue Jan 17, 2024
Closed
@roseegalla
Copy link

It seems like there was a relatively recent PR to add grpc labels to traces hidden behind a feature flag (open-telemetry/opentelemetry-dotnet#5130). Are there any discussions or a proposed timeline on adding RPC Metrics?

@reyang reyang transferred this issue from open-telemetry/opentelemetry-dotnet May 13, 2024
@reyang reyang added the comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:instrumentation.grpcnetclient Things related to OpenTelemetry.Instrumentation.GrpcNetClient enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cijothomas @reyang @roseegalla