set TraceState field in OTLP Exporter
#4331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yun-Ting
changed the title
TraceState field in OTLP Exporter
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4331 +/- ##
==========================================
- Coverage 84.67% 84.64% -0.04%
==========================================
Files 298 298
Lines 11936 11937 +1
==========================================
- Hits 10107 10104 -3
- Misses 1829 1833 +4
|
reyang
reviewed
Mar 24, 2023
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ActivityExtensions.cs
Show resolved
Hide resolved
reyang
approved these changes
Mar 24, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Mar 24, 2023
cijothomas
reviewed
Mar 24, 2023
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public void ToOtlpSpanTraceStateTest(bool traceStateWasSet) |
There was a problem hiding this comment.
do we have existing tests for checking other things from activity context? like spanid,traceid etc? we could just modify it instead of adding dedicated tests.
There was a problem hiding this comment.
I can add traceState assertions to ToOtlpSpanTest.
Personally, I prefer to keep unit tests small.
cijothomas
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4010
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes