Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP Exporter does not set trace_state field #4010

Closed
zacharycmontoya opened this issue Dec 14, 2022 · 3 comments · Fixed by #4331
Closed

OTLP Exporter does not set trace_state field #4010

zacharycmontoya opened this issue Dec 14, 2022 · 3 comments · Fixed by #4331
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@zacharycmontoya
Copy link

Feature Request

Is your feature request related to a problem?

I don't have an urgent issue, but I would like the OTLP exporter to set the span's trace_state field, to have the complete data represented in the OTLP trace.

Describe the solution you'd like:

I would like the OTLP exporter to set the TraceState property when converting the System.Diagnostics.Activity object to its corresponding OpenTelemetry.Proto.Trace.V1.Span object.

Describe alternatives you've considered.

None. The OTLP exporter alone is responsible for exporting the Activity in the form of an OTLP span.

Additional Context

I'm happy to submit a PR to implement this, but I wanted to know if there was a previous decision to omit this, or if this was just missed.

@zacharycmontoya zacharycmontoya added the enhancement New feature or request label Dec 14, 2022
@cijothomas cijothomas added the bug Something isn't working label Feb 14, 2023
@cijothomas cijothomas added this to the 1.5.0 milestone Feb 14, 2023
@cijothomas
Copy link
Member

Tagging for consideration in 1.5

@cijothomas
Copy link
Member

@Yun-Ting Could you check and see if you can take this?

@Yun-Ting
Copy link
Contributor

Hi @zacharycmontoya, please let me know if you are interested in working on this, I can help to review. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants