[DI] Rename DI package to OpenTelemetry.Api.ProviderBuilderExtensions #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyang
approved these changes
Jan 31, 2023
alanwest
approved these changes
Jan 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4125 +/- ##
==========================================
+ Coverage 85.57% 85.66% +0.08%
==========================================
Files 293 293
Lines 11359 11359
==========================================
+ Hits 9721 9731 +10
+ Misses 1638 1628 -10
|
Kielek
approved these changes
Jan 31, 2023
cijothomas
reviewed
Jan 31, 2023
| [IServiceCollection](https://learn.microsoft.com/dotnet/api/microsoft.extensions.dependencyinjection.iservicecollection)). | ||
|
|
||
| The `OpenTelemetry.Api.ProviderBuilderExtensions` package is intended for | ||
| instrumentation library authors who need to integrate with the OpenTelemetry SDK |
There was a problem hiding this comment.
"who need to provide DI based configuration, but without taking OTel SDK dependency.. "
Feel free to grab this/similar, in a separate PR if needed.
xiang17
added a commit
to xiang17/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Feb 2, 2023
…s.DependencyInjection` was renamed to `OpenTelemetry.Api.ProviderBuilderExtensions` open-telemetry/opentelemetry-dotnet#4125
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4083
Changes
OpenTelemetry.Extensions.DependencyInjection->OpenTelemetry.Api.ProviderBuilderExtensionsTODOs
CHANGELOG.mdupdated for non-trivial changes