Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Updates for DI tweaks #4127

Merged
merged 2 commits into from
Jan 31, 2023
Merged

[docs] Updates for DI tweaks #4127

merged 2 commits into from
Jan 31, 2023

Conversation

CodeBlanch
Copy link
Member

Relates to #4103
Relates to #4125

Changes

  • Documentation updates for recent DI changes.

@CodeBlanch CodeBlanch requested a review from a team January 31, 2023 20:32
cijothomas
cijothomas approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
https://github.com/open-telemetry/opentelemetry-dotnet/pull/4127/files#r1092453607 Please check this too, especially considering if a .NET FW user reads the doc.

@cijothomas cijothomas merged commit 0b69b37 into open-telemetry:main Jan 31, 2023
This was referenced Jan 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodeBlanch @cijothomas @reyang