-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge net7 branch to main: Updates DiagnosticSource to 7.0.0 + net7 instrumentation improvements #3539
Conversation
This reverts commit 25df7e8.
Codecov Report
@@ Coverage Diff @@
## main #3539 +/- ##
==========================================
- Coverage 86.80% 86.71% -0.09%
==========================================
Files 275 275
Lines 9949 9959 +10
==========================================
Hits 8636 8636
- Misses 1313 1323 +10
|
Fixed a few small things. I think this is good to merge. We definitely need a changelog - maybe there's some dependency on #3448, but assuming we're dropping |
Will we have a version where we support both .NET Core 3.1 and .NET 7? There might be overlapping time where both are officially supported. .NET Core 3.1 ends support in December 13, 2022. Edit: .NET 7 is scheduled to release in November 2022. Only one month later. Maybe OTel will just release after .NET Core 3.1 ends support. |
@xiang17 Technically OpenTelemetry .NET would likely continue to work with netcoreapp3.1 even though we've upgraded to DiagnosticSource v7. A netcoreapp3.1 application could still add us as a dependency because we currently still target netstandard2.0. Though, users will receive a build warning. However, one option on the table in #3448 is to drop our netstandard targets. That said, we haven't settled on a final strategy or timeline yet for how we'll coordinate our next stable release with the release of .NET 7. |
Sounds cool! I was trying to validate what you said but got a build error after adding |
Work included is primarily from the following PRs