[.NET7.0] Http client activity source migration #3415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## net7.0 #3415 +/- ##
==========================================
+ Coverage 86.10% 86.14% +0.03%
==========================================
Files 258 258
Lines 9261 9279 +18
==========================================
+ Hits 7974 7993 +19
+ Misses 1287 1286 -1
|
vishweshbankwar
changed the title
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
CodeBlanch
reviewed
Jul 12, 2022
src/OpenTelemetry.Instrumentation.Http/HttpClientInstrumentation.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Jul 12, 2022
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
Show resolved
Hide resolved
alanwest
approved these changes
Jul 12, 2022
alanwest
removed
the
Stale
cijothomas
reviewed
Jul 16, 2022
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jul 16, 2022
src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs
Outdated
Show resolved
Hide resolved
…lerDiagnosticListener.cs Co-authored-by: Cijo Thomas <[email protected]>
…lerDiagnosticListener.cs Co-authored-by: Cijo Thomas <[email protected]>
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
github-actions
bot
removed
the
Stale
alanwest
pushed a commit
to alanwest/opentelemetry-dotnet
that referenced
this pull request
Aug 3, 2022
pellared
pushed a commit
to open-telemetry/opentelemetry-dotnet-instrumentation
that referenced
this pull request
Nov 25, 2022
* Bump OpenTelemetry.AutoInstrumentation dependencies to 1.4.0-beta.3 and other released to the newest versions * Adjust setting up Prometheus exporter based on https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.Prometheus.HttpListener/CHANGELOG.md#140-alpha2 * Remove Microsoft.Extensions.Logging.Abstractions from duplicated libraries list After upgrade all places references 7.0.0 * Reintroduce DiagnosticSource source to additional deps it is needed by .NET 6 applications * Bump Additional Dependencies to 7.0 as we should always bring the newest packages * Use HttpClientInstrumentationOptions instead of HttpWebRequestInstrumentationOptions based on open-telemetry/opentelemetry-dotnet@399fbcf * Add Microsoft.Extensions.Configuration.EnvironmentVariables to Additional Store introduced by open-telemetry/opentelemetry-dotnet@f191e846d37283e82272f6daa95df10aec4edd7bhttps://github.com/open-telemetry/opentelemetry-dotnet/commit/f191e846d37283e82272f6daa95df10aec4edd7b * Fix references in Smoke tests * Update SourceNames for Http Instrumentation due to https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md#100-rc96 * Change expected span names for Http Instrumentation changes due to dotnet/runtime@d8c0170 open-telemetry/opentelemetry-dotnet#3415 open-telemetry/opentelemetry-dotnet@8add3db * Update Sql Integration name due to https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.SqlClient/CHANGELOG.md#100-rc95 * Update tests dependencies * Binding to System.Memory 4.0.1.2 to avoid conflicts with loaded library Workaround will be fixed in scope of #1646 * Update distributed structure * Remove reference to HttpWebRequestInstrumentationOptions from documentation. It was removed from instrumentation package * Dotnet format fix * Propagate workaround from 411e778 to TestApplication.Http.NetFramework * Bump OpenTelemetry.Instrumentation.Runtime to 1.1.0-beta.1 * Remove todo comment we expect that it will be needed shortly * Remove DiagnosticSource reference from TestApplication.Http It is not used in the application, so it is loaded from additional store * Update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3018
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes