Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor string extensions #3306

Merged
merged 5 commits into from
May 25, 2022

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented May 25, 2022

Fixes #2919.

Changes

Remove extensions methods related to the BCL (string!) classes to reduce noisy in IntelliSense.

For significant contributions please make sure you have completed the following items:

@Kielek Kielek requested a review from a team May 25, 2022 07:23
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #3306 (14cd22c) into main (292b416) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3306      +/-   ##
==========================================
- Coverage   85.48%   85.43%   -0.05%     
==========================================
  Files         263      264       +1     
  Lines        9505     9505              
==========================================
- Hits         8125     8121       -4     
- Misses       1380     1384       +4     
Impacted Files Coverage Δ
...TelemetryProtocol/OtlpExporterOptionsExtensions.cs 97.72% <ø> (-0.15%) ⬇️
...Telemetry.Exporter.Jaeger/JaegerExporterOptions.cs 100.00% <100.00%> (ø)
...ry.Exporter.Jaeger/JaegerExporterProtocolParser.cs 100.00% <100.00%> (ø)
....OpenTelemetryProtocol/OtlpExportProtocolParser.cs 100.00% <100.00%> (ø)
...orter.OpenTelemetryProtocol/OtlpExporterOptions.cs 100.00% <100.00%> (ø)
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 73.27% <0.00%> (-0.87%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit 8aa1778 into open-telemetry:main May 25, 2022
@Kielek Kielek deleted the refactor-string-extensions branch May 25, 2022 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove extensions method from BCL classes
4 participants