Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extensions method from BCL classes #2919

Closed
Kielek opened this issue Feb 18, 2022 · 0 comments · Fixed by #3306
Closed

Remove extensions method from BCL classes #2919

Kielek opened this issue Feb 18, 2022 · 0 comments · Fixed by #3306
Assignees
Labels
enhancement New feature or request

Comments

@Kielek
Copy link
Contributor

Kielek commented Feb 18, 2022

Feature Request

Remove extensions methods related to the BCL (string!) classes. It could be noisy for Intellisense,

Describe the solution you'd like:

Consider methods like

internal static JaegerExportProtocol? ParseProtocol(string value)

or

internal static bool ParseProtocol(string value, out JaegerExportProtocol result)

instead of

public static JaegerExportProtocol? ToJaegerExportProtocol(this string protocol) =>

Describe alternatives you've considered.

Which alternative solutions or features have you considered?

Additional Context

Based on #2875 (comment) and #2914 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants