Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary search histograms #3251

Closed
wants to merge 89 commits into from
Closed

Binary search histograms #3251

wants to merge 89 commits into from

Conversation

mic-max
Copy link
Contributor

@mic-max mic-max commented May 4, 2022

Fixes #3248

Changes

When using 140+ buckets for a histogram, it will use binary search instead of linear search.

TODO include results for benchmarks in main and update the HistogramBenchmarks.cs with results from this branch

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

mic-max and others added 30 commits September 23, 2021 14:10
commit 080927d
Author: Cijo Thomas <[email protected]>
Date:   Thu Sep 23 10:07:05 2021 -0700

    Changelog update for 1.2.0.alpha4 (#2407)

commit 61aaf2e
Author: Reiley Yang <[email protected]>
Date:   Thu Sep 23 09:37:18 2021 -0700

    Simplify tutorials (#2406)

commit 78baf7c
Author: Reiley Yang <[email protected]>
Date:   Thu Sep 23 08:02:09 2021 -0700

    Implement the metrics dispose/shutdown logic (#2404)

commit 256fc2d
Author: Michael Maxwell <[email protected]>
Date:   Wed Sep 22 17:35:15 2021 -0400

    Use `Stopwatch.StartNew()` (#2403)
…her.cs


yes thank you, good catch

Co-authored-by: Robert Pająk <[email protected]>
cijothomas and others added 28 commits May 4, 2022 15:19
* Update changelog for next release

* rename alpha to beta
* Remove net5.0 from Zipkin and replace with net6.0

* Public api
* Cleanup net5.0 apps and readme

* api doc
* Update main readme with project status

* minor adjustments
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 1 to 2.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v1...v2)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This reverts commit b03b18b.
* remove w3c check

* unnecessary usings
* Fix handling of OTLP ArrayValue attributes

* Update changelog

Co-authored-by: Cijo Thomas <[email protected]>
@mic-max mic-max closed this May 4, 2022
@mic-max mic-max deleted the binary-search-histograms branch May 4, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use binary search for histograms with LOTS of buckets
8 participants